fix: update type of CollectionEntry ids#11435
Conversation
The legacy content collections were generating an union of all possible ids. This is no longer the case--it's just a string.
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
|
Thanks for your patience, @fedetibaldo , while we're a little behind with docs PRs while we've been getting things ready and out for Launch Week! I'm going to ask @ArmandPhilippot to review this PR for you. I suspect that it is correct as stated: the "Example Type" is meant to give an example as to what the (yes, string) might look like. I believe the type given is shown as an example to be more helpful than just saying that the type will be |
ArmandPhilippot
left a comment
There was a problem hiding this comment.
This is indeed correct. I believe the Example Type is rather what we used with the legacy API and we forgot to update that. I think this change will be more useful because it doesn't imply that autocomplete can be expected here.
Thanks @fedetibaldo and sorry for the delay! Welcome to Team Docs. 🥳
Description (required)
The legacy content collections were generating an union of all possible ids. This is no longer the case--it's just a string. This change reflects that.
First-time contributor to Astro Docs?
Yes. @fedetibaldo is my handle on Discord