-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[docs]: Clarify astro:env/server variable evaluation and secret handling #12818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs]: Clarify astro:env/server variable evaluation and secret handling #12818
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
|
Hi @fkatsuhiro. Thank you for grabbing the issue and helping us fix it! Your contribution is well-written and easy to read, but I don't think this information belongs in a "caution" block. We try to use as few notes (and especially cautions!) in docs as possible. If everything is a big note to call your attention, then nothing stands out! 😄 (And, it gives us more room to add things like examples, since your proposal mentions there is a way to address the problem, but doesn't show an example of how to do it!) Instead, when we are simply describing "how something works", it should be in regular paragraph text. Sometimes this means a new section heading so that specific information about a subtopic is easy to find and link to. And sometimes, new information is not just "one new paragraph" or section, but means reading the whole section and seeing if this information is well presented when the topic is explained. It involves figuring out how to update existing text to make sure the necessary information is presented in the appropriate place, at the appropriate time. So, how would you propose we update docs if you were not allowed to use any kind of note/caution? Could you try again without doing so? |
Thank you for your reply ! |
0744a73 to
87b6867
Compare
|
@sarah11918 san
Could you take another look when you have time? |
|
Thank you, I absolutely will take a look! 🙌 But, please remove all the translations and only submit changes to docs in English. We have a translation procedure for handling the other languages. |
|
@florian-lefebvre Can you review the content and placement here? One thing I noticed is that earlier on the page we say this ("only validated at runtime"), which seems to contradict the content here (unless there is a further nuance not expressed)? Can you provide clarity?
|
Thank you for letting me know about the translation procedure! |
|
Mmmh tricky. I suppose it depends what we mean by So I'm not sure a new heading is necessary, adding it below the "secret server variables" bullet point might make more sense (and then we can discuss editing the content to fit better). Wdyt Sarah? |
|
Thanks for your suggestion! |
florian-lefebvre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
T&D ftw!
|
We were there when the secrets were discussed... At T&D!!! |
|
I struggled to understand in Talking & Docing, but I was there |
|
We looked at this one in painful detail on Talking and Doc'ing because we thought we could work this in to our explanation of how secret server variables work. I think we did it! |

Description (required)
Added documentation regarding
secret server variablevalidation during the build process.Since
astro:env/serveris evaluated on import, builds can fail if secrets are missing. This PR adds a section explaining this behavior and how to fix it using dummy values.Related issues & labels (optional)
astro:envsecrets may throw on static pages #12581improve or update documentation