Skip to content

Fix font-family syntax in fonts.mdx#13433

Merged
ArmandPhilippot merged 2 commits intowithastro:mainfrom
pawelgrzybek:patch-1
Mar 12, 2026
Merged

Fix font-family syntax in fonts.mdx#13433
ArmandPhilippot merged 2 commits intowithastro:mainfrom
pawelgrzybek:patch-1

Conversation

@pawelgrzybek
Copy link
Contributor

Description (required)

The name of the custom property shouldn't be quoted.

@netlify
Copy link

netlify bot commented Mar 12, 2026

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 85ee284
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/69b34d3ea32d1600077e7785
😎 Deploy Preview https://deploy-preview-13433--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Mar 12, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/fonts.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@ArmandPhilippot
Copy link
Member

Thanks for the PR, but I don't think we need this change.

This is a CSS variable, using var() doesn't require quotes. See: https://developer.mozilla.org/en-US/docs/Web/CSS/Guides/Cascading_variables/Using_custom_properties#referencing_custom_properties_with_var

If you have troubles using the Font API do not hesitate to create a support thread on Discord, our community will be happy to help you!

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry for closing this. I misread the diff. I thought you were adding quotes... 🤦🏽

Thank you for noticing this, and welcome to team docs! 🥳

@ArmandPhilippot ArmandPhilippot merged commit 4cdf4ca into withastro:main Mar 12, 2026
10 checks passed
bashrocks added a commit to bashrocks/withastro-docs that referenced this pull request Mar 12, 2026
Fix font-family syntax in fonts.mdx (withastro#13433)
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants