Skip to content

remove CF Pages workaround#13466

Merged
alexanderniebuhr merged 7 commits intomainfrom
remove-cf-pages-workaround
Mar 18, 2026
Merged

remove CF Pages workaround#13466
alexanderniebuhr merged 7 commits intomainfrom
remove-cf-pages-workaround

Conversation

@alexanderniebuhr
Copy link
Member

Description (required)

  • This Workaround somehow made it to the final docs. However after talking with Cloudflare and discussing internally we found out Pages is not supported and won't be supported, not even with a manual workaround.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@netlify
Copy link

netlify bot commented Mar 14, 2026

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit baab2cc
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/69ba43fb6231150008488636
😎 Deploy Preview https://deploy-preview-13466--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Mar 14, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/deploy/cloudflare.mdx Source changed, localizations will be marked as outdated.
en/guides/integrations-guide/cloudflare.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This file looks good to me (so, I'm approving to avoid blocking anything) but I think we would need to also update the deploy guide if the adapter no longer supports Pages (sorry, I missed that with my previous review), see https://docs.astro.build/en/guides/deploy/cloudflare/#cloudflare-pages

if it only consists of removing mentions of Cloudflare Pages mentions, we can handle that if you want! But, it would be helpful if someone familiar with Cloudflare scanned that page to check that nothing else needs to be deleted/modified.

@alexanderniebuhr
Copy link
Member Author

Let me quickly add the update to that page 😓

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thans! LGTM. I left a nit and a question but nothing really blocking here!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the name still "Workers & Pages"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny enough it actually still is, however we can improve the explanation a bit 😓

image

Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@alexanderniebuhr
Copy link
Member Author

Not waiting for another round of reviews, since I already got approval twice 😓

@alexanderniebuhr alexanderniebuhr merged commit b24695b into main Mar 18, 2026
10 checks passed
@alexanderniebuhr alexanderniebuhr deleted the remove-cf-pages-workaround branch March 18, 2026 06:33
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Mar 18, 2026
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants