Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Thank you! This file looks good to me (so, I'm approving to avoid blocking anything) but I think we would need to also update the deploy guide if the adapter no longer supports Pages (sorry, I missed that with my previous review), see https://docs.astro.build/en/guides/deploy/cloudflare/#cloudflare-pages
if it only consists of removing mentions of Cloudflare Pages mentions, we can handle that if you want! But, it would be helpful if someone familiar with Cloudflare scanned that page to check that nothing else needs to be deleted/modified.
|
Let me quickly add the update to that page 😓 |
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Thans! LGTM. I left a nit and a question but nothing really blocking here!
There was a problem hiding this comment.
Is the name still "Workers & Pages"?
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
|
Not waiting for another round of reviews, since I already got approval twice 😓 |

Description (required)
Related issues & labels (optional)