docs: add experimental advanced routing reference page#13792
docs: add experimental advanced routing reference page#13792ArmandPhilippot merged 35 commits intov6.3from
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
…ing.mdx Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Thanks Matthew, the wording looks good to me! No suggestions to improve that, only for the formatting:
- We usually don't put the arguments in the headings (ie.
middleware()instead ofmiddleware(state, next)). This helps make the links easier to parse when sharing them:#middlewareinstead of#middlewarestate-next - I think an API block for the methods is also helpful since some of them have different arguments or different return types.
I also noticed a few em dashes. We usually don't use them in docs. I don't know if we want to stay consistent with this or not. I don't have a strong opinion.
Question: Do we need a section for ContextProvider?
I see that the FetchState types often refer to create and finalize. Maybe it would be helpful to document it so we can link to ContextProvider.create() and ContextProvider.finalize(). I think this helps users navigate easily to between related sections.
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
yanthomasdev
left a comment
There was a problem hiding this comment.
Thanks @matthewp, just adding a few suggestions to remove all these emdashes that are not necessary, and then LGTM
…ing.mdx Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
…ing.mdx Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
…ing.mdx Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
…ing.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ing.mdx Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
…ing.mdx Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
…ing.mdx Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
…ing.mdx Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
# Conflicts: # astro.sidebar.ts
|
@ArmandPhilippot I've updated this PR to also document |
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Thank you! This looks ready to me! 🙌🏽
Description (required)
Documents the upcoming
experimental.advancedRoutingflag.For Astro version:
6.2. See astro PR #16366.