Add id attribute explanation.#2511
Merged
Jutanium merged 3 commits intowithastro:mainfrom Feb 2, 2023
Merged
Conversation
I was curious about what the id property was, because I was wondering why I would want to over-write it with my own custom slugs. To clarify, I think using the filename makes a lot of sense and it was my guess, but the attribute's name "id" doesn't make that immediately clear. Sorry if I did anything wrong. :)
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
sarah11918
reviewed
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was curious about what the id property was, because I was wondering why I would want to over-write it with my own custom slugs.
To clarify, I think using the filename makes a lot of sense and it was my guess, but the attribute's name "id" doesn't make that immediately clear.
Sorry if I did anything wrong. :)
What kind of changes does this PR include?
Description