Skip to content

fix(speech-generation): return correct finish reason type in Google provider #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kamilbenkirane merged 1 commit into from
Dec 24, 2025
Merged

fix(speech-generation): return correct finish reason type in Google provider #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...s/capabilities/speech-generation/src/celeste_speech_generation/providers/google/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from celeste.parameters import ParameterMapper
from celeste_speech_generation.client import SpeechGenerationClient
from celeste_speech_generation.io import (
SpeechGenerationFinishReason,
SpeechGenerationInput,
SpeechGenerationUsage,
)
Expand Down Expand Up @@ -41,6 +42,13 @@ def _parse_usage(self, response_data: dict[str, Any]) -> SpeechGenerationUsage:
usage = super()._parse_usage(response_data)
return SpeechGenerationUsage(**usage)

def _parse_finish_reason(
self, response_data: dict[str, Any]
) -> SpeechGenerationFinishReason:
"""Parse finish reason from response."""
finish_reason = super()._parse_finish_reason(response_data)
return SpeechGenerationFinishReason(reason=finish_reason.reason)

def _parse_content(
self,
response_data: dict[str, Any],
Expand Down
Loading