fix: align _parse_usage return types with RawUsage contract#174
Merged
Kamilbenkirane merged 2 commits intomainfrom Feb 23, 2026
Merged
fix: align _parse_usage return types with RawUsage contract#174Kamilbenkirane merged 2 commits intomainfrom
Kamilbenkirane merged 2 commits intomainfrom
Conversation
Three modality-level _parse_usage overrides returned typed ImageUsage objects instead of dicts, causing _get_usage() to crash with "argument after ** must be a mapping, not ImageUsage". Also remove redundant _parse_usage and _parse_finish_reason overrides from the modality template — _get_usage/_get_finish_reason in APIMixin already handle the raw → typed conversion via ClassVars. Closes #173
- Use UsageField.NUM_IMAGES constant instead of raw "num_images" string
- Add regression tests for _parse_usage dict return type contract
- Fix ConcreteModalityClient test helper (same Usage() → {} bug)
- Restore _parse_finish_reason scaffold in modality template
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_parse_usageoverrides returned typedImageUsageobjects instead ofRawUsagedicts, causing_get_usage()to crash withImageUsage() argument after ** must be a mapping, not ImageUsageon Gemini/Imagen image generation_parse_usageand_parse_finish_reasonoverrides from the modality template —_get_usage/_get_finish_reasoninAPIMixinalready handle raw → typed conversion via_usage_class/_finish_reason_classClassVarsTest plan
Closes #173