Skip to content

feat: add new model definitions for Google, OpenAI, and xAI#213

Merged
Kamilbenkirane merged 3 commits intomainfrom
feat/new-models
Mar 19, 2026
Merged

feat: add new model definitions for Google, OpenAI, and xAI#213
Kamilbenkirane merged 3 commits intomainfrom
feat/new-models

Conversation

@Kamilbenkirane
Copy link
Member

@Kamilbenkirane Kamilbenkirane commented Mar 19, 2026

Summary

Adds new model registrations:

  • Google: gemini-3.1-flash-image-preview (images), gemini-3.1-flash-lite-preview (text)
  • OpenAI: gpt-5.4, gpt-5.4-pro, gpt-5.4-mini, gpt-5.4-nano
  • xAI: grok-4.20-beta-0309-reasoning, grok-4.20-beta-0309-non-reasoning

@claude
Copy link

claude bot commented Mar 19, 2026

Code review

1 issue found.

Bug: Placeholder display_name in gemini-3.1-flash-image-preview

src/celeste/modalities/images/providers/google/models.py, line 105:

display_name="Nano Banana 2",

This appears to be a test/placeholder value that was accidentally left in. Every other model in this file and in this PR uses a descriptive name matching the model ID (e.g., "Gemini 3.1 Flash Lite Preview", "GPT-5.4", "Grok 4.20 Beta 0309 Reasoning").

See:

id="gemini-3.1-flash-image-preview",
provider=Provider.GOOGLE,
display_name="Nano Banana 2",
operations={Modality.IMAGES: {Operation.GENERATE, Operation.EDIT}},
parameter_constraints={

Suggested fix: Change to display_name="Gemini 3.1 Flash Image Preview".


🤖 Generated with Claude Code

@claude
Copy link

claude bot commented Mar 19, 2026

Code review - 1 issue found: placeholder display_name='Nano Banana 2' in src/celeste/modalities/images/providers/google/models.py line 105 for model gemini-3.1-flash-image-preview. All other models use real product names. Should be something like 'Gemini 3.1 Flash Image Preview'. See:

id="gemini-3.1-flash-image-preview",
provider=Provider.GOOGLE,
display_name="Nano Banana 2",
operations={Modality.IMAGES: {Operation.GENERATE, Operation.EDIT}},
parameter_constraints={

@Kamilbenkirane Kamilbenkirane merged commit 380d179 into main Mar 19, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant