fix: add ToolSupport to legacy OpenAI/xAI models#232
Merged
Kamilbenkirane merged 1 commit intofeat/unified-tools-parameterfrom Mar 25, 2026
Merged
Conversation
gpt-4-turbo, gpt-4, gpt-3.5-turbo, and grok-2-vision-1212 all support tool calling but were missing TextParameter.TOOLS in their parameter constraints. Added ToolSupport(tools=[]) so they properly advertise tool support in model metadata. Fixes #225
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TextParameter.TOOLS: ToolSupport(tools=[])to 4 legacy models that support tool calling but were missing the declaration:gpt-4-turbo,gpt-4,gpt-3.5-turbo(OpenAI)grok-2-vision-1212(xAI)ToolSupport(tools=[])means "no built-in server tools, user-defined function tools are fine" — this is correct for legacy models that don't have native web searchTest plan
Fixes #225