refactor: standardize capability naming to kebab-case#24
refactor: standardize capability naming to kebab-case#24Kamilbenkirane merged 2 commits intomainfrom
Conversation
- Update version in root pyproject.toml - Update version in text-generation package - This version includes optional dependencies configuration
- Change capability enum values from snake_case to kebab-case (e.g., text_generation → text-generation) - Update entry point name to match kebab-case convention - Move integration tests to package-specific directories - Update Makefile to reflect new test paths - Remove deprecated claude-sonnet-3-7 model - Update error messages to use capability enums directly
Code Review SummaryThis PR introduces a solid refactoring to standardize capability naming from snake_case to kebab-case. The changes are well-implemented and comprehensive. ✅ StrengthsCode Quality
Best Practices
🔍 Areas for Improvement1. Breaking Change Documentation (High Priority)Issue: This is a breaking change that will affect users, but there's no CHANGELOG or migration guide. Recommendation:
2. Test Path Organization (Medium Priority)Location: Makefile:44 The glob pattern packages/*/tests/integration_tests/ might cause issues if some packages don't have integration tests yet. Recommendation:
3. Error Message Improvement (Low Priority)Locations: src/celeste/client.py:33, src/celeste/client.py:243 Consider whether error messages would be clearer showing both the enum value and name to help users understand both the string value and enum name. 4. Model Removal Documentation (Low Priority)Location: packages/text-generation/src/celeste_text_generation/providers/anthropic/models.py Document why claude-sonnet-3-7 model was removed (deprecated by Anthropic, placeholder, etc.) 🔒 Security Considerations✅ No security concerns identified. The changes are purely refactoring with no impact on authentication, input validation, or data handling. ⚡ Performance Considerations✅ No performance impact. The changes are compile-time (enum values) with no runtime performance implications. 🧪 Test CoverageExcellent: All affected tests updated comprehensively with good use of parametrized tests and proper regex escaping. 📋 Recommendations SummaryMust Have (Before Merge):
Should Have:
Nice to Have:
🎯 Overall AssessmentQuality Score: 8.5/10 This is a well-executed refactoring that improves consistency across the codebase. The main gap is documentation around the breaking change. Once the CHANGELOG is added and the migration path is clear for users, this is ready to merge. Approval Status: ✅ Approved with minor recommendations Great work on maintaining test coverage and consistency throughout this refactoring! |
Summary
This PR standardizes capability naming conventions across the codebase by changing from snake_case to kebab-case, improving consistency and alignment with package naming conventions.
Changes
Capability Naming Standardization
text_generation→text-generationimage_generation→image-generationimage_intelligence→image-intelligencevideo_generation→video-generationvideo_intelligence→video-intelligenceaudio_intelligence→audio-intelligencePackage Entry Points
pyproject.tomlfromtext_generationtotext-generationto match the new naming conventionTest Organization
tests/integration_tests/to package-specific locations (packages/*/tests/integration_tests/)Code Quality Improvements
.valuefor better type safetyclaude-sonnet-3-7model from Anthropic providerImpact
Testing