You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR Review: Version Bump to 0.2.2 and Image Intelligence Dependency
Summary
This PR bumps the version from 0.2.1 to 0.2.2 and adds celeste-image-intelligence as an optional dependency. Overall, the changes are clean and follow semantic versioning for a minor patch release.
Code Quality and Best Practices ✅
Strengths:
Clean, focused change that does one thing well
Proper formatting with multi-line array for the all extra (improves readability)
Consistent version constraint pattern (>=0.2.1) matching existing dependencies
Follows the repository's existing structure and conventions
Observations:
The commit message follows the conventional commit format (chore:) appropriately
Version bump to 0.2.2 is a patch increment, which is correct for adding optional dependencies
Potential Issues ⚠️
Critical Issue - Missing Workspace Configuration:
The PR adds celeste-image-intelligence>=0.2.1 to optional dependencies but does not add it to [tool.uv.sources] section. Currently only these are defined:
Required fix: Add the following line to [tool.uv.sources] at pyproject.toml:65:
celeste-image-intelligence = { workspace = true }
Without this, users installing celeste-ai[image-intelligence] or celeste-ai[all] will look for the package on PyPI instead of using the workspace package, which will likely fail since the package directory doesn't exist yet in the repository (packages/image-intelligence/ is missing).
Minor Concern - Package Not Present:
The packages/image-intelligence/ directory doesn't exist in the current repository (only image-generation and text-generation are present)
This suggests the image-intelligence package might be added in a separate PR or branch
Consider whether this version bump should wait until the actual package is merged
Performance Considerations ✅
No performance impact - this is purely a dependency configuration change.
Security Concerns ✅
No security concerns identified:
Adding an optional dependency to the same trusted namespace (celeste-*)
No changes to runtime code or security-critical configurations
Version constraint >=0.2.1 allows future patch/minor updates (standard practice)
Test Coverage 📋
Current State:
No tests appear to directly validate optional dependency installation
The capability IMAGE_INTELLIGENCE already exists in src/celeste/core.py:33, suggesting the feature is planned/partially implemented
Recommendations:
Consider adding a CI check that validates all optional dependencies can be installed successfully
Add a test case that ensures celeste-ai[all] includes all expected capabilities
Document the installation options in README.md (currently only shows text-generation, image-generation, and all)
Documentation 📝
Missing Updates:
The README.md should be updated to include the new optional dependency:
uv add "celeste-ai[text-generation]"# Text only
uv add "celeste-ai[image-generation]"# Image generation
uv add "celeste-ai[image-intelligence]"# Image intelligence (NEW)
uv add "celeste-ai[all]"# Everything
⚠️ Ensure the packages/image-intelligence/ package exists or will be added before this is released
📝 Update README.md installation instructions to include the new optional dependency
🧪 Consider running uv sync --extra all locally to verify all dependencies resolve correctly
Nice to Have:
Add a CHANGELOG.md entry documenting this version bump
Add CI validation for optional dependency installation
Overall Assessment
Status:⚠️ Changes Requested
The PR is well-structured and follows conventions, but requires the workspace source configuration to be added for the package to work correctly. Once the [tool.uv.sources] section is updated, this will be ready to merge (assuming the image-intelligence package exists or will be added concurrently).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump version to 0.2.2 and add celeste-image-intelligence as an optional dependency