chore: bump version to 0.2.6

[Kamilbenkirane]

Bump version to 0.2.6 and update package versions.

Changes

• Bump main package version: 0.2.5 → 0.2.6
• Bump text-generation package version: 0.2.1 → 0.2.2
• Bump image-generation package version: 0.2.1 → 0.2.2
• Update dependency references in main pyproject.toml

[claude]

Code Review - PR #38: chore: bump version to 0.2.6

Summary

This PR bumps the main package version from 0.2.5 to 0.2.6 and updates the text-generation and image-generation sub-packages from 0.2.1 to 0.2.2, along with their dependency references.

---

✅ Positive Findings

1. Consistent Version Bumping: All version updates are applied consistently across the three affected files
2. Dependency Alignment: The main pyproject.toml correctly updates both the [project.optional-dependencies] section AND the all extras to reference the new sub-package versions
3. Semantic Versioning: The version bumps follow semantic versioning (patch version increments)
4. Clean Diff: The changes are minimal and focused solely on version numbers

---

⚠️ Issues & Recommendations

1. Missing Changelog Documentation

Severity: Medium
Location: Repository root

• The repository lacks a CHANGELOG.md file to document version changes
• Recommendation: Consider adding a CHANGELOG.md following Keep a Changelog format to track what changed in each version. This is especially important for a library with multiple sub-packages.

2. Incomplete Version Consistency Check

Severity: Low
Location: pyproject.toml:38-39

• The PR updates text-generation and image-generation but doesn't touch:
  • image-intelligence (still at 0.2.1)
  • speech-generation (still at 0.2.3)
• Question: Are these packages intentionally left at their current versions, or should they be reviewed for consistency?
• Recommendation: Document which packages are included in each release, even if some aren't updated

3. No Associated Release Notes

Severity: Medium

• The PR description mentions version bumps but doesn't explain WHAT changed in the sub-packages between 0.2.1 → 0.2.2
• Recommendation: Either:
  • Link to commits/PRs that introduced the changes warranting the version bump
  • Include a brief summary of changes in the PR description
  • Maintain separate CHANGELOGs in each package directory

4. Missing Git Tag Strategy Validation

Severity: Low

• The CI workflow references tags with pattern v* (line 6 of .github/workflows/ci.yml)
• Recommendation: Ensure git tags are created for this release (e.g., v0.2.6, text-generation-v0.2.2, image-generation-v0.2.2) and document the tagging strategy

---

🔍 Code Quality Assessment

• Formatting: ✅ Changes are clean and properly formatted
• Type Safety: ✅ No code changes, no type safety impact
• Testing: ⚠️ No test changes required, but verify CI passes
• Security: ✅ No security implications (version metadata only)
• Performance: ✅ No performance impact

---

📋 Pre-Merge Checklist

Before merging, please confirm:

• All CI checks pass (format-check, lint, type-check, security, tests)
• The changes in sub-packages between 0.2.1 → 0.2.2 are documented somewhere (commits, PR descriptions, or CHANGELOG)
• This version bump is intentional and doesn't skip any unreleased changes
• Git tags will be created post-merge for v0.2.6
• PyPI publishing workflow is ready (if applicable)

---

💡 Future Improvements

1. Automated Version Bumping: Consider tools like commitizen, semantic-release, or bump2version to automate version bumping with changelog generation
2. Monorepo Versioning Strategy: Document whether sub-packages version independently or follow the main package version
3. Version Validation CI: Add a CI check to ensure dependency versions in pyproject.toml match the actual package versions in packages/*/pyproject.toml

---

🎯 Verdict

APPROVED ✅ with minor recommendations

The changes are technically correct and safe to merge. The concerns raised are primarily about process and documentation rather than code correctness. This PR can be merged once CI passes, but I strongly recommend addressing the changelog and release notes documentation for better maintainability.

---

Review completed by Claude Code

[claude]

PR Review: Version Bump to 0.2.6

Thank you for this release PR! Overall, this is a clean version bump with an important test infrastructure improvement. Here's my detailed review:

✅ Strengths

1. Consistent Version Bumping: All version increments follow semantic versioning correctly (0.2.1 → 0.2.2 for sub-packages, 0.2.5 → 0.2.6 for main package)

2. Critical Bug Fix: The new conftest.py fixture addresses a real issue with pytest-asyncio and pytest-xdist integration. The cleanup_http_clients fixture properly ensures HTTP clients are closed before the event loop terminates, preventing "Event loop is closed" errors.

3. Good Documentation: The fixture docstring clearly explains the purpose and the problem it solves

4. Proper Import: Correctly imports from celeste.http which exposes close_all_http_clients as part of its public API (see http.py:237)

🔍 Code Quality

packages/text-generation/tests/integration_tests/conftest.py:6-18

• ✅ Clean implementation using yield pattern for teardown
• ✅ Proper use of autouse=True to automatically apply to all integration tests
• ✅ Async fixture correctly decorated with @pytest_asyncio.fixture
• ✅ No unused imports (both pytest and pytest_asyncio are needed)

💡 Suggestions

1. Consider Adding to image-generation Package:

   • The image-generation package also has integration tests at packages/image-generation/tests/integration_tests/ that likely use HTTP clients
   • Should this same fixture be added there for consistency? The HTTP client cleanup would benefit those tests as well
   • Location: packages/image-generation/tests/integration_tests/conftest.py

2. Minor Enhancement - Scope Clarification:
   While the current implementation is correct, you could explicitly set scope="function" for clarity:

   @pytest_asyncio.fixture(autouse=True, scope="function")
   async def cleanup_http_clients() -> None:

   This is the default, but being explicit helps document the intended behavior.

🔒 Security & Performance

• ✅ No security concerns
• ✅ No performance issues - cleanup is necessary and efficient
• ✅ The close_all_http_clients() function includes proper error handling (see http.py:221-229)

🧪 Test Coverage

The PR doesn't include tests for the new conftest fixture itself, which is acceptable since:

• It's a test infrastructure component
• The fixture will be exercised by all integration tests automatically
• Testing pytest fixtures can be complex and may not add significant value here

📝 Version Dependencies

The dependency updates in pyproject.toml are correctly aligned:

• Lines 35-36: Optional dependencies updated to >=0.2.2
• Lines 40-41: "all" bundle updated to match

Summary

Recommendation: ✅ Approve with minor suggestion

This PR is ready to merge. The version bumps are clean and the test fixture is a valuable addition that solves a real problem with async test cleanup.

The only suggestion is to consider whether image-generation integration tests would benefit from the same conftest fixture for consistency and to prevent similar issues there.

Great work on improving the test infrastructure!

[claude]

Pull Request Review - PR #38: Bump version to 0.2.6

Overview

This PR includes version bumps and an important bug fix for pytest-xdist compatibility. The changes are well-structured with clear commit messages.

Code Quality & Best Practices

✅ Strengths

1. Clear commit messages: Following conventional commit format (chore:, fix:)
2. Proper fixture pattern: The new conftest.py follows established patterns in the codebase (similar to unit test fixtures)
3. Good documentation: Docstrings clearly explain the purpose and the problem being solved
4. Correct type annotations: Using AsyncGenerator[None, None] for the async fixture
5. Import from collections.abc: Using collections.abc.AsyncGenerator instead of typing.AsyncGenerator (modern Python 3.12+ practice)

📝 Observations

1. Version consistency: All package versions are properly synchronized (0.2.1 → 0.2.2, main 0.2.5 → 0.2.6)
2. Dependency updates: Correctly updated in both optional-dependencies and all sections

Potential Issues & Concerns

⚠️ Minor Issues

1. Missing fixture in image-generation package

   • Location: packages/image-generation/tests/integration_tests/
   • Issue: The image-generation package also has integration tests but doesn't have a conftest.py with the cleanup fixture
   • Impact: If pytest-xdist is used for image-generation integration tests, they may encounter the same "Event loop is closed" errors
   • Recommendation: Consider adding the same fixture to packages/image-generation/tests/integration_tests/conftest.py for consistency

2. Fixture placement consideration

   • Current: Fixture is in packages/text-generation/tests/integration_tests/conftest.py
   • Consideration: Since close_all_http_clients() is a shared utility from the main package (celeste.http), you might want to verify if this fixture should also be in the main test suite's conftest
   • Note: This is acceptable as-is if integration tests are only in the sub-packages

Performance Considerations

✅ Good practices

• Fixture runs after each test (yield before cleanup): Ensures resources are freed immediately
• Uses autouse=True: Automatically applies to all tests, preventing accidental resource leaks
• Minimal overhead: The close_all_http_clients() function already handles errors gracefully (as seen in http.py:221-229)

Security Concerns

✅ No security issues identified

• The changes are internal testing infrastructure only
• No API keys, credentials, or sensitive data exposed
• HTTP client cleanup improves resource management

Test Coverage

⚠️ Considerations

1. New fixture is untested

   • The conftest.py file itself has no dedicated tests
   • Impact: Low - the fixture is simple and calls a well-tested function (close_all_http_clients)
   • Recommendation: Consider adding a test in the unit tests to verify the fixture behavior, though not critical

2. Integration test verification

   • Question: Have the integration tests been run with pytest-xdist to verify this fixes the issue?
   • Recommendation: Run pytest -n auto packages/text-generation/tests/integration_tests/ to verify the fix

Additional Recommendations

1. Documentation update: Consider updating the README or contributing guide to mention pytest-xdist compatibility if not already documented

2. Consistency check: Verify if other packages (image-generation, image-intelligence, speech-generation) need similar fixtures

3. CI/CD verification: Ensure CI pipeline runs with pytest-xdist to catch similar issues in the future

Summary

Overall Assessment: ✅ Approve with minor suggestions

The PR is well-executed with:

• Clean version bumps
• Important bug fix for pytest-xdist compatibility
• Good code quality and documentation
• No breaking changes

Recommended Actions:

1. Add similar fixture to image-generation integration tests for consistency
2. Verify the fix works with pytest -n auto on integration tests
3. Consider if main test suite needs similar cleanup

Risk Level: Low - Changes are isolated to version numbers and test infrastructure

Great work on identifying and fixing the pytest-xdist event loop issue! 🎯