fix: detect changes correctly when pushing tags#58
Merged
Kamilbenkirane merged 1 commit intomainfrom Dec 5, 2025
Merged
Conversation
Fix the publish workflow to properly detect changes when pushing tags. Tag pushes don't have github.event.before, so we now compare against the previous tag instead. This ensures integration tests and publish jobs run correctly for tag-based releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When pushing a tag, the publish workflow was skipping integration tests and publish jobs because
github.event.beforeis empty for tag push events. This caused thedetect-changesjob to fail to detect any changes.Solution
get-basestep that finds the previous tag usinggit describe --tags --abbrev=0 HEAD^paths-filterto use the previous tag as the base instead ofgithub.event.beforeTesting
This fix ensures that when a tag is pushed: