Skip to content

Conversation

@abhisht51
Copy link
Contributor

@abhisht51 abhisht51 commented Jun 9, 2023

added support for

  • aws help with isPersistent: true flag

@abhisht51 abhisht51 requested review from fedeci and mschrage as code owners June 9, 2023 05:53
@abhisht51 abhisht51 marked this pull request as draft June 9, 2023 05:53
@withfig-bot
Copy link
Contributor

withfig-bot commented Jun 9, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@withfig-bot
Copy link
Contributor

withfig-bot commented Jun 9, 2023

Overview

src/aws.ts:

Info:

Script:
aws configure list-profiles
postProcess(function):

 function (out) {
    if (out.trim() == "") {
      return [];
    }

    return out.split("\n").map((line) => ({
      name: line,
      icon: "👤",
    }));
  }

URLs:

  • http://docs.aws.amazon.com/cli/latest/userguide/cli-chap-getting-started.html
  • https://budgets.amazonaws.com
  • https://ce.us-east-1.amazonaws.com
  • https://service.chime.aws.amazon.com.
  • https://elasticbeanstalk.s3.amazonaws.com/doc/2010-12-01/AWSElasticBeanstalk.wsdl.
  • https://api.pricing.us-east-1.amazonaws.com
  • http://aws.amazon.com/simpledb/
  • https://tools.ietf.org/html/rfc8628).

@withfig-bot
Copy link
Contributor

Hello @abhisht51,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

@abhisht51 abhisht51 mentioned this pull request Jun 9, 2023
3 tasks
@abhisht51 abhisht51 force-pushed the feature/aws-help-spec-enhancement branch from cdbb346 to 552e557 Compare June 10, 2023 11:18
@abhisht51 abhisht51 changed the title feat: [aws] Add help subcommand for A initial feat: [aws] Add help \ Jun 10, 2023
@abhisht51 abhisht51 changed the title feat: [aws] Add help \ feat: [aws] Add help subcommand Jun 10, 2023
@abhisht51
Copy link
Contributor Author

@viniciusanchieta can you assist me on how I can go åbout signing CLA

@grant0417
Copy link
Member

You need to post a comment with only the content like:

I have read the CLA Document and I hereby sign the CLA

@grant0417
Copy link
Member

Here is an example: #2003 (comment)

@abhisht51
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

withfig-bot added a commit that referenced this pull request Jul 29, 2023
@abhisht51 abhisht51 marked this pull request as ready for review July 29, 2023 05:30
@grant0417 grant0417 merged commit 08545aa into withfig:master Jul 30, 2023
@withfig withfig locked and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants