Skip to content
This repository was archived by the owner on Oct 11, 2022. It is now read-only.

Conversation

@brianlovin
Copy link
Contributor

Status

  • WIP
  • Ready for review
  • Needs testing

Deploy after merge (delete what needn't be deployed)

  • iris (api)
  • hyperion (frontend)

Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Les do it

@mxstbr mxstbr merged commit 29ebd11 into alpha Mar 19, 2018
@mxstbr mxstbr deleted the fix-219-bugs branch March 19, 2018 14:54
@spectrum-bot
Copy link

Fails
🚫

Danger failed to run dangerfile.js.

Error HttpError

{"message":"No commit found for the ref fix-219-bugs","documentation_url":"https://developer.github.com/v3/repos/contents/"}
HttpError: {"message":"No commit found for the ref fix-219-bugs","documentation_url":"https://developer.github.com/v3/repos/contents/"}
    at IncomingMessage.response.on (/home/circleci/spectrum/node_modules/@octokit/rest/lib/request/request.js:73:18)
    at emitNone (events.js:111:20)
    at IncomingMessage.emit (events.js:208:7)
    at endReadableNT (_stream_readable.js:1064:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

Dangerfile

68| jest();
69| 
70| // Make sure nobody does a it.only and blocks our entire test-suite from running
71| noTestShortcuts({
72|   testFilePredicate: filePath => filePath.endsWith('.test.js'),
--------------------^
73| });
74| 
75| schedule(noConsole({ whitelist: ['error'] }));
76| 

Generated by 🚫 dangerJS

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants