This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Render mobile message replies #3088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryota-murakami
previously approved these changes
May 17, 2018
| ${props => (props.expanded ? '' : 'max-height: 100px;')}; | ||
| `; | ||
|
|
||
| export const QuoteGradient = styled(LinearGradient).attrs({ |
Contributor
There was a problem hiding this comment.
oh, i don't know Expo provided LinearGradient & there is such as cool way to handle CSS Gradients by styled-components on ReactNative😋
Also removes the duplicate `onlyContainsEmoji`.
brianlovin
reviewed
May 23, 2018
| "dev": true, | ||
| "minify": false, | ||
| "urlRandomness": "66-qcw" | ||
| "urlRandomness": "2s-bjc" |
Contributor
There was a problem hiding this comment.
Should this have notes around why this needs to be this specific thing?
Contributor
Author
There was a problem hiding this comment.
It's automatically generated by Expo
Contributor
|
Overall this looks good to me @mxstbr - I think you'll have the fastest ability to resolve those conflicts, then we can get this merged :) |
Contributor
Author
|
Will resolve and merge tomorrow! |
brianlovin
previously approved these changes
May 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
TODO
Current status: