This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Mobile direct messages view #3132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
mxstbr
commented
May 23, 2018
| import styled from 'styled-components/native'; | ||
|
|
||
| export default styled.View` | ||
| flex-direction: row; |
Contributor
Author
There was a problem hiding this comment.
- Added
<Row />and<Column />components
mxstbr
commented
May 23, 2018
| import * as React from 'react'; | ||
| import { Button } from 'react-native'; | ||
| import { StackNavigator } from 'react-navigation'; | ||
| import idx from 'idx'; |
Contributor
Author
There was a problem hiding this comment.
- Added
idxto the deps and used it throughout, shoutout to @alejandronanez for the tip
mxstbr
commented
May 23, 2018
| } | ||
| } | ||
|
|
||
| export function timeDifference(current: number, previous: ?number): string { |
Contributor
Author
There was a problem hiding this comment.
- Moved these to
shared, removed duplicates fromsrc
Contributor
Author
|
@brianlovin this is pretty much ready for review! 😍 Note that this doesn't have the chat input/messages enhancements from #3088, so don't expect the messages screen to look that great yet. (marked some important-ish points inline) |
brianlovin
approved these changes
May 23, 2018
Contributor
brianlovin
left a comment
brianlovin
left a comment
There was a problem hiding this comment.
LGTM! Architecture makes sense, will dig in locally and help tidy up things as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
TODO
<Messages />to use<InfiniteList />Current status