This repository was archived by the owner on Oct 11, 2022. It is now read-only.
2.4.11 #3385
Merged
2.4.11 #3385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't work.
This was necessary when we didn't use `react-loadable` for SSR, but now that we do this is entirely unused so we can just get rid of it!
@brianlovin this _should_ fix the ?t param even when loaded with SSR, right? The issue previously was that we'd mount with an active thread, but the dashboard would still switch to the first one that's loaded once the thread feed loads.
We unset the mounted thread ID before any threads were loaded, so when they finally did load in mountedThreadId was null and the app thought it had to select the first thread. This fixes it by only doing the "unset mounted thread id" logic after threads have already loaded! 🎉
Also refactor render code a bit to be nicer
This reverts commit 313f473.
This is cherry-picked from #3334 since that's not quite done yet, but this should go live asap.
…nce-again Fix ServiceWorker caching
Upgrade mobile to Expo SDK 28
Fix dashboard SSR
Generated by 🚫 dangerJS |
Contributor
|
@brianlovin @mxstbr Wow, Dashboard speeeeeed amazing!😜🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)