-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Import emails to invite to community #4621
Conversation
|
@brianlovin any ideas where best to put the help text about the supported file type and format? Do we have an existing pattern for that? |
Generated by 🚫 dangerJS |
We don't have an existing pattern for this. Maybe it could look like this instead: I don't think we need to describe the optional method of uploading an array of objects; if people find that error message, they can do it, but ideally they just upload the array of emails. What do you think? |
|
Looks good to me, will clean this up! |
|
Updated based on your suggestions, ready for another review @brianlovin! |
|
@mxstbr check 9e9e31a for some logic changes:
You can see this in action better by uploading [
"hi@bryn.io",
"hi@brianlovin.com",
"hi@mxstbr.com",
"hi@bryn.io",
"hi@brianlovin.com",
"hi@mxstbr.com",
"hi@bryn.io",
"hi@brianlovin.com",
"hi@mxstbr.com",
"bad.email",
"shouldnt@work.com"
]Then in the frontend, try typing one of the existing emails (like |
mxstbr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice, let's ship it!
|
Once tests pass I'll merge :) |




Status
Deploy after merge (delete what needn't be deployed)
Related issues (delete if you don't know of any)
Closes #4611
Adds ability to import JSON file with emails of users to be invited to community. Demo (note that UI is not polished, only the functionality):
Click to see test files
users-emails.json:
users-with-names.json:
[ { "email": "arnold@schwarzenegger.at", "name": "Arnold" }, { "email": "elon@musk.com", "name": "Elon" }, { "email": "notanemail", "name": "Wrong" } ]Todo