feat: implement burning of slashed collateral (WIP0023)#2277
Closed
drcpu-github wants to merge 1 commit into
Closed
feat: implement burning of slashed collateral (WIP0023)#2277drcpu-github wants to merge 1 commit into
drcpu-github wants to merge 1 commit into
Conversation
Member
|
I have changed the base of this PR from |
aesedepece
force-pushed
the
witnet-1.6
branch
from
e31608e to
40c0f80
Compare
Member
|
This is now on 1.6 and on its road to master in #2354 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made all relevant Tally tests conditional on WIP0023 being activated. I could not find a proper way of enabling all tests with a new WIP being activated, so I added a temporary placeholder in
wip_info()andtest_wip_info(). If you uncomment those, you can verify all tests pass with and without WIP0023 being active.I was not sure if I should just update the WIP in
initialize_wip_information()nor the associated tests, but for now I did.