Conversation
ameerabuf
reviewed
Mar 15, 2026
Contributor
ameerabuf
left a comment
ameerabuf
left a comment
There was a problem hiding this comment.
I agree with the direction, and it does seem to be the same information in much less text, but I do not feel comfortable removing so much without first testing to see there is no regression. We can use Monty's QA-flow on this branch or something like this...
Added customEffect rules to hover and click; Fixes to viewprogress.md
Added missing composite effect property in types
Added TOCs
ameerabuf
requested changes
Mar 18, 2026
Contributor
ameerabuf
left a comment
ameerabuf
left a comment
There was a problem hiding this comment.
read click and hover. There were already quite a few comments, some are critical IMO, so I submit now and I will continue with the other triggers.
ameerabuf
requested changes
Mar 18, 2026
ameerabuf
requested changes
Mar 18, 2026
ameerabuf
reviewed
Mar 18, 2026
ameerabuf
requested changes
Mar 19, 2026
ameerabuf
reviewed
Mar 24, 2026
ameerabuf
reviewed
Mar 24, 2026
ameerabuf
reviewed
Mar 24, 2026
Comment on lines
+123
to
+124
| // Use keyframeEffect, namedEffect, or customEffect as in Rules 1–2 | ||
| keyframeEffect: { name: '[EFFECT_NAME]', keyframes: [EFFECT_KEYFRAMES] }, |
Contributor
There was a problem hiding this comment.
then let's not write a template of a keyframeEffect, it is just confusing
Collaborator
Author
There was a problem hiding this comment.
Do you have another suggestion?
ameerabuf
reviewed
Mar 24, 2026
ameerabuf
previously approved these changes
Apr 12, 2026
Contributor
ameerabuf
left a comment
ameerabuf
left a comment
There was a problem hiding this comment.
Approved to allow merge and to proceed working on it. However, there are many unresolved comments that were not handled and I think are important, some even critical. I keep them unresolved so we can return to them in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
hover.mdclick.mdviewprogress.mdviewenter.mdpointermove.mdintegration.mdscroll-list.mdfull-lean.md