Updates to <Calendar> styles to allow customization#66
Merged
tautvilas merged 3 commits intowix:masterfrom Jul 13, 2017
Merged
Conversation
sibelius
approved these changes
Jun 20, 2017
Contributor
|
Hi, thanks for pull request. Is |
Contributor
Author
|
It looks like it hasn't been properly documented but I was able to find references in some commits as well as https://github.com/facebook/react-native/blob/235b16d93287061a09c4624e612b5dc4f960ce47/React/Base/RCTConvert.m#L612 They have defined a font called "System" to be the default font for the platform. And I'll check lint, looks like I missed something pretty simple! |
Contributor
|
System works fine |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request gives the ability to set appStyle props to change the fontFamily and fontSize for component.
The default "System" font and default sizes are retained and used as a backup if the props are not defined.
There likely is a more elegant way to do this and if you have any suggestions I'd be happy to make modifications.
New props
Original
With props added
