Merged
Conversation
… of github.com:wix/react-native-navigation into bugfix/(RN77-NA)-Android-Enable-Native-Unit-Tests-#8011
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enable Android Robolectric unit tests disabled since New Architecture migration
When RNN migrated to React Native's New Architecture (Fabric), 27 Android unit test classes were disabled with
@IgnorebecauseReactViewnow loads native libraries (rninstanceviaSoLoader) during construction — which fails under Robolectric since there's no real Android runtime.The fix introduces two Robolectric shadow classes to intercept the native initialization chain without modifying any production code:
ShadowSoLoader— stubsSoLoader.loadLibrarycalls as no-ops, preventing native.soloading attempts.ShadowReactView— shadowsReactView's constructor to invokeFrameLayout's constructor directly, bypassingReactHost.createSurface()and the entire native rendering pipeline. Also shadows lifecycle methods (onAttachedToWindow,start,destroy) to prevent NPEs from the missingreactSurface.Supporting changes:
TestApplication.reactHostreturns a Mockito mock instead of callinggetDefaultReactHost(), which would trigger native initialization.SimpleViewController.SimpleViewextendsFrameLayoutdirectly instead ofReactView, implementingReactComponentinterface explicitly.MockedStaticdouble-close bug inBaseTest.beforeEach.Result: All 687 unit tests now pass (2 pre-existing method-level
@Ignores remain).