Root component Appear not working in first time after launch#8295
Open
markdevocht wants to merge 3 commits intomasterfrom
Open
Root component Appear not working in first time after launch#8295markdevocht wants to merge 3 commits intomasterfrom
markdevocht wants to merge 3 commits intomasterfrom
Conversation
1 task
…n-first-time-after-launch
…n-first-time-after-launch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Android —
ReactView: deferRNN.ComponentWillAppear/RNN.ComponentDidAppearuntilReactContextis available and the Fabric surface reports content (isRendered()), so JS canbindComponentbefore per-screen appear events. Aligns with iOSRNNReactView(pending appear until mount). Relates to #8265 (rootcomponentDidAppearmissed on first launch).Problem
componentDidAppearonly works afterNavigation.events().bindComponent(this)in mount. If native emitsRNN.ComponentDidAppearbefore that,ComponentEventsObserverhas no listeners for thatcomponentIdand the callback is dropped.ComponentViewControllervisibility before the surface had mounted content; iOS already defers inRNNReactView.What changed
android/src/main/java/com/reactnativenavigation/react/ReactView.javagetReactContext() == nullor!isRendered()sendComponentStopanddestroy