[Fix] handle searchBar focus on mergeOptions for existing searchController#8319
Open
IsaacIsrael wants to merge 2 commits into
Open
[Fix] handle searchBar focus on mergeOptions for existing searchController#8319IsaacIsrael wants to merge 2 commits into
IsaacIsrael wants to merge 2 commits into
Conversation
…ontroller When calling mergeOptions with searchBar.focus: true on a screen that already has a searchController, the focus was silently ignored because the focus logic only ran in the initial creation branch. This adds focus handling in the else branch so becomeFirstResponder is called on existing search controllers, enabling re-focus on screen reappear (e.g. switching back to a bottom tab). Fixes wix#8318 Co-authored-by: Cursor <cursoragent@cursor.com>
IsaacIsrael
changed the title
yedidyak
approved these changes
Jun 2, 2026
Contributor
yedidyak
left a comment
yedidyak
left a comment
There was a problem hiding this comment.
Looks good. I added a focused iOS regression test that verifies mergeOptions refocuses an existing search controller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mergeOptionsis called withtopBar.searchBar.focus: trueon a screen whosesearchControlleralready exists, the focus was silently ignored — thebecomeFirstResponderlogic only ran in the initial-creation branchelsebranch so the search bar refocuses on existing search controllers (e.g., when switching back to a bottom tab)Fixes #8318
Test plan
searchBar: { visible: true, focus: true }Navigation.mergeOptions(componentId, { topBar: { searchBar: { visible: true, focus: true } } })oncomponentDidAppearMade with Cursor