Feat/featur highlight extras #506
Conversation
| /** | ||
| * The headline to be displayed above the title | ||
| */ | ||
| headline: PropTypes.string, |
There was a problem hiding this comment.
I think this is very specific to what Growth team wants, why not allowing styling the title and the message so thy can achieve the typography they want?
There was a problem hiding this comment.
Your call. You want me to change it?
There was a problem hiding this comment.
The point was to control the text design though
There was a problem hiding this comment.
yea, but it will never good enough, especially if it's an open source component.
someone will always want to customize it
I think enforcement of styling should be more in the private lib than the public one
There was a problem hiding this comment.
Ok. I'll change it
There was a problem hiding this comment.
So you think they will never use the three of them together?
There was a problem hiding this comment.
if the idea was to add a third type of content so people can have 3 different contents then I guess this prop make sense
if we're just adding another content prop with the exact same styling of the title prop just so people can render it under the message then it's weird, if that's the case it makes more sense to have custom styling over the those content
Since the current requirement was to still have two contents just in a different order I assume letting them customize the style feels more right
Adding borderRadius, headline and pageControlProps props.