This repository was archived by the owner on Feb 14, 2025. It is now read-only.
Fix WiX v3.11 templates #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the Native CA template and target redirect for VS2017/MSBuild15. This change is dependent on wixtoolset/wix3#442 Fixes wixtoolset/issues#5536
Improve the error message to explicitly call out v3.11 since new targets are required for MSBuild15 to work correctly. Also, make redirects imports consistent with project template imports so error messages are consistent. Fixes wixtoolset/issues#5564
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to wixtoolset/wix3#442, this fixes the top priority WiX v3.11 bugs.