Skip to content

Conversation

@thijstriemstra
Copy link
Contributor

@thijstriemstra thijstriemstra commented Jan 28, 2021

Build example on d1 mini and uno boards using platformio.

@thijstriemstra
Copy link
Contributor Author

thijstriemstra commented Jan 28, 2021

@wizard97 can you enable github actions for this repository? I would've hoped my PR would enable/trigger it but alas, no.

See https://github.com/wizard97/ArduinoProcessScheduler/actions

Copy link
Owner

@wizard97 wizard97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, it would be cool to have some CI testing.

@thijstriemstra
Copy link
Contributor Author

@wizard97 should be good now.

@thijstriemstra
Copy link
Contributor Author

at some point I will probably use this library on ESP32. Any reason RingBuf disabled support for ESP32 or is it just untested?

@thijstriemstra
Copy link
Contributor Author

ping @wizard97

@wizard97
Copy link
Owner

Sorry for the slow turnaround. The ESP32 software stack was just not really developed at the time I was working on this library. Totally interested in making sure it is supported.

Does it not build on ESP32 currently? Also, can you squash the latter 2 commits since together they are effectively nops?

@thijstriemstra
Copy link
Contributor Author

Does it not build on ESP32 currently?

No, it seems RingBuf explicitly disabled ESP32 supported, see log here: https://github.com/thijstriemstra/ArduinoProcessScheduler/runs/1784375565 (showing why it's useful to have these github actions to figure out if something's working/still working).

Also, can you squash the latter 2 commits since together they are effectively nops?

Github has a 'squash commits' option when you merge a pull request. This will squash the commits into a single one.

@wizard97 can you also make a new release once this pr is merged?

@thijstriemstra
Copy link
Contributor Author

ping @wizard97

@wizard97 wizard97 merged commit 7719a52 into wizard97:master Apr 26, 2021
@wizard97
Copy link
Owner

Thanks, sorry for the delayed response!

@thijstriemstra thijstriemstra deleted the patch-2 branch April 26, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants