-
Notifications
You must be signed in to change notification settings - Fork 16
ci: build with platformio and github actions #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@wizard97 can you enable github actions for this repository? I would've hoped my PR would enable/trigger it but alas, no. See https://github.com/wizard97/ArduinoProcessScheduler/actions |
wizard97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this, it would be cool to have some CI testing.
|
@wizard97 should be good now. |
|
at some point I will probably use this library on ESP32. Any reason RingBuf disabled support for ESP32 or is it just untested? |
|
ping @wizard97 |
|
Sorry for the slow turnaround. The ESP32 software stack was just not really developed at the time I was working on this library. Totally interested in making sure it is supported. Does it not build on ESP32 currently? Also, can you squash the latter 2 commits since together they are effectively nops? |
No, it seems RingBuf explicitly disabled ESP32 supported, see log here: https://github.com/thijstriemstra/ArduinoProcessScheduler/runs/1784375565 (showing why it's useful to have these github actions to figure out if something's working/still working).
Github has a 'squash commits' option when you merge a pull request. This will squash the commits into a single one. @wizard97 can you also make a new release once this pr is merged? |
|
ping @wizard97 |
|
Thanks, sorry for the delayed response! |
Build example on d1 mini and uno boards using platformio.