Merged
Conversation
Adding link to polish translation
Adds disabled rules: `max-lines`, `no-mixed-operators`, `rest-spread-spacing`, `object-curly-newline`
Parens around a single argument aren't in line with the js guide:
If your function takes a single argument and doesn’t use braces,
omit the parentheses.
https://github.com/airbnb/javascript/blob/0814be638f22b01a8e49efd77094be24055a3d48/README.md#arrows--one-arg-parens
Another rule violation:
Wrap JSX tags in parentheses when they span more than one line.
https://github.com/airbnb/javascript/blob/0814be638f22b01a8e49efd77094be24055a3d48/react/README.md#parentheses
- `no-named-as-default` - `no-named-as-default-member` - `no-extraneous-dependencies` - `extensions`
Specifically, this is to require parens to avoid cognitive overhead about precedence.
…-import`, `prefer-default-export`
The "bad" and "good" diffs in section 19.2 had different text; making them the same to avoid confusion about what the difference is.
According to the official React documentation string refs are considered legacy and will be deprecated in the future.
[eslint config] [react] [breaking] Prevent using string refs.
- It follows [ES6 styleguide](https://github.com/airbnb/javascript#naming--leading-underscore) - eslint plugin is configured this way : `'no-underscore-dangle': [2, { allowAfterThis: false }],`
This rule was added by 1.10.0. I am setting it to be disabled because it is very project-specific, so it doesn't make sense to enable it here. https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-restricted-paths.md I found the sections of this file a little confusing, so I didn't know where to put it. I think it would be better to simply alphabetize the rules but I'll leave that for another time.
- drop support for node 4.
…imit to 4.
Specifically, this is to allow this frequent pattern:
```js
$.ajax({
…
}).done(() => {
…
}).fail(() => {
…
}).always(() => {
…
});
```
…`eslint-find-rules`
… `eslint`, `eslint-plugin-import`, `eslint-plugin-react`
…ore patterns for config files Fixes #1168
…r non-required props
…-import`, `eslint-plugin-react`
…` ignore patterns for test files Fixes #1174
…dd some comments to ignore patterns.
The example showed a template string being used with no interpolation as "good". While it met the rule being described, it violated another rule for no reason.
This style guide recommends using `i += 1` over `i++`. Even though this appears in a "bad" example, the example will be clearest if it is "bad" in fewer ways.
As is, actual «good» usage fires the arrow-parens rule. Parenthesis are needed to follow the current style guide.
…, `eslint-config-airbnb-base`
…require-default-props`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.