Skip to content

Use format = "keras"#14

Merged
wlandau merged 43 commits intomasterfrom
10
Aug 30, 2019
Merged

Use format = "keras"#14
wlandau merged 43 commits intomasterfrom
10

Conversation

@wlandau
Copy link
Owner

@wlandau wlandau commented Aug 18, 2019

Summary

Use format = "keras" throughout the workshop for added convenience (and efficiency in production workflows). Related: ropensci/drake#977.

Related GitHub issues and pull requests

Checklist

@wlandau wlandau self-assigned this Aug 18, 2019
@lintr-bot
Copy link

inst/notebooks/5-files/R/plan.R:8:17: style: Do not place spaces around code in parentheses or square brackets.

model = target( # Name this target `progression` instead of `model`.
                ^

inst/notebooks/5-files/R/plan.R:9:1: style: lines should not be more than 80 characters.

​  	train_model(data, rec), # Set `model_file = file_out("model.h5")` in the call to train_model().
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

inst/notebooks/5-files/R/plan.R:9:3: style: Use two spaces to indent, never tabs.

​  	train_model(data, rec), # Set `model_file = file_out("model.h5")` in the call to train_model().
  ^

inst/notebooks/5-files/R/plan.R:10:1: style: lines should not be more than 80 characters.

format = "keras" # The target value is no longer a model, so remove this line with the format.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

inst/notebooks/5-files/R/plan.R:10:3: style: Use two spaces to indent, never tabs.

format = "keras" # The target value is no longer a model, so remove this line with the format.
  ^

inst/notebooks/5-files/R/plan.R:10:16: style: Put spaces around all infix operators.

format = "keras" # The target value is no longer a model, so remove this line with the format.
              ~^~

inst/tutorials/learndrakeflow/R/plan.R:5:3: style: Use two spaces to indent, never tabs.

​  	train_model(data, rec),
  ^

inst/tutorials/learndrakeflow/R/plan.R:6:3: style: Use two spaces to indent, never tabs.

format = "keras"
  ^

inst/tutorials/learndrakeflow/R/plan.R:6:16: style: Put spaces around all infix operators.

format = "keras"
              ~^~

@codecov-io
Copy link

codecov-io commented Aug 18, 2019

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   61.53%   61.53%           
=======================================
  Files           3        3           
  Lines          26       26           
=======================================
  Hits           16       16           
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c468ab...1c7c809. Read the comment docs.

@wlandau wlandau merged commit dabb543 into master Aug 30, 2019
@wlandau wlandau deleted the 10 branch August 30, 2019 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants