Skip to content

Inherit dark-mode defaults from Material's built-in slate scheme#319

Merged
softhack007 merged 3 commits into
mainfrom
copilot/improve-code-snippets-readability
May 12, 2026
Merged

Inherit dark-mode defaults from Material's built-in slate scheme#319
softhack007 merged 3 commits into
mainfrom
copilot/improve-code-snippets-readability

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 12, 2026

The custom wled dark scheme was defined entirely from scratch, requiring manual specification of every token color — and missing ones (comments, operators, punctuation, etc.) fell through to light-mode defaults, causing near-invisible text in code blocks.

Changes

  • mkdocs.yml: rename palette scheme wledslate, so Material loads its full built-in dark palette as the base layer before extra.css is applied
  • extra.css: update selector to match ("wled""slate"); drop 8 manually-specified token overrides (comment, operator, punctuation, function, constant, variable, special, generic) now inherited from slate

Any token not explicitly overridden now falls through to Material's slate defaults automatically, including future upstream improvements.

Summary by CodeRabbit

  • Documentation
    • Documentation styling has been updated to use the Material "slate" dark color scheme instead of the previous "wled" theme. Color palette configurations and CSS styling overrides have been realigned for consistency, ensuring a cohesive visual experience across all documentation pages.

Review Change Stack

Copilot AI and others added 3 commits May 12, 2026 22:30
Agent-Logs-Url: https://github.com/wled/WLED-Docs/sessions/91be7ee2-cf92-41b9-8a3d-73103b60dc6b

Co-authored-by: softhack007 <91616163+softhack007@users.noreply.github.com>
@softhack007
Copy link
Copy Markdown
Member

@coderabbitai review

@coderabbitai

This comment was marked as outdated.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e870e09f-37d3-4ba5-bc2c-ba4b7e182fcd

📥 Commits

Reviewing files that changed from the base of the PR and between 0e6b3fa and 292410c.

📒 Files selected for processing (2)
  • docs/assets/stylesheets/extra.css
  • mkdocs.yml

Walkthrough

Documentation theme migrated from custom "wled" color scheme to Material's "slate" scheme. The mkdocs configuration updates the palette entry and stylesheet selectors are changed to target the new scheme consistently.

Changes

Theme Color Scheme Migration

Layer / File(s) Summary
Theme color scheme update
mkdocs.yml, docs/assets/stylesheets/extra.css
Material theme palette entry switches scheme from wled to slate, and stylesheet selectors for color-scheme wrapper and table links are updated to target slate instead of wled.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 From wled to slate we hop along,
Dark colors dancing strong and true,
The theme reborn where it belongs,
Material's palette fresh and new!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: switching from a custom 'wled' dark scheme to Material's built-in 'slate' scheme to inherit better defaults.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch copilot/improve-code-snippets-readability

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@softhack007 softhack007 merged commit af1c278 into main May 12, 2026
2 checks passed
@softhack007 softhack007 deleted the copilot/improve-code-snippets-readability branch May 12, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants