Inherit dark-mode defaults from Material's built-in slate scheme#319
Conversation
Agent-Logs-Url: https://github.com/wled/WLED-Docs/sessions/f1f81694-bc7f-4421-bccc-ff9783f111f0 Co-authored-by: softhack007 <91616163+softhack007@users.noreply.github.com>
Agent-Logs-Url: https://github.com/wled/WLED-Docs/sessions/91be7ee2-cf92-41b9-8a3d-73103b60dc6b Co-authored-by: softhack007 <91616163+softhack007@users.noreply.github.com>
Agent-Logs-Url: https://github.com/wled/WLED-Docs/sessions/91be7ee2-cf92-41b9-8a3d-73103b60dc6b Co-authored-by: softhack007 <91616163+softhack007@users.noreply.github.com>
|
@coderabbitai review |
This comment was marked as outdated.
This comment was marked as outdated.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughDocumentation theme migrated from custom "wled" color scheme to Material's "slate" scheme. The mkdocs configuration updates the palette entry and stylesheet selectors are changed to target the new scheme consistently. ChangesTheme Color Scheme Migration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The custom
wleddark scheme was defined entirely from scratch, requiring manual specification of every token color — and missing ones (comments, operators, punctuation, etc.) fell through to light-mode defaults, causing near-invisible text in code blocks.Changes
mkdocs.yml: rename palette schemewled→slate, so Material loads its full built-in dark palette as the base layer beforeextra.cssis appliedextra.css: update selector to match ("wled"→"slate"); drop 8 manually-specified token overrides (comment,operator,punctuation,function,constant,variable,special,generic) now inherited from slateAny token not explicitly overridden now falls through to Material's slate defaults automatically, including future upstream improvements.
Summary by CodeRabbit