Added usermod "battery status basic" #2127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ahhhh sorry.. i knew i forgot something... I will get right on it. |
commit 0f84552 Author: itCarl <mewes.maximilian@gmx.de> Date: Tue Aug 10 18:35:15 2021 +0200 updated readme and added image showing info modal commit 055579f Author: itCarl <mewes.maximilian@gmx.de> Date: Mon Aug 9 20:53:07 2021 +0200 small map function fix commit 811614c Author: itCarl <mewes.maximilian@gmx.de> Date: Mon Aug 9 19:35:21 2021 +0200 updated ui commit cadf2e2 Author: itCarl <mewes.maximilian@gmx.de> Date: Mon Aug 9 16:07:32 2021 +0200 added usermod battery_status_basic
Contributor
Author
|
It's my first "real world" PR... so if i forgot something to mention or if i made a mistake somewhere please let me know. |
blazoncek
reviewed
Aug 15, 2021
Contributor
blazoncek
left a comment
blazoncek
left a comment
There was a problem hiding this comment.
I think you should follow recent progress in usermod development and allow for runtime configuration.
I also found some oddities.
usermods/battery_status_basic/usermod_v2_battery_status_basic.h
Outdated
Show resolved
Hide resolved
usermods/battery_status_basic/usermod_v2_battery_status_basic.h
Outdated
Show resolved
Hide resolved
Member
|
Thank you for the useful usermod :) Is this ready to merge? |
Contributor
|
I intend to review the code thoroughly if you wish. |
Contributor
Author
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i realised that my last pr was bs... so im trying it again.. .-.
this usermod show the battery level in the info modal.. thats all it does for now.
im planning to add more features soon but for now it is what it is.
trying to resolve Issue/FR:
[Feature Request] Battery status? #316