Basic Usermod Overlay support & Seven Segment UM #2261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 29, 2021 19:23
blazoncek
reviewed
Oct 10, 2021
|
|
||
| void addToConfig(JsonObject& root) | ||
| { | ||
| JsonObject top = root[FPSTR("sevenseg")]; |
Contributor
There was a problem hiding this comment.
Can you, please, rewrite string use to minimize flash usage?
Samples are in quite a few recent usermods, including Temperature, Multi Relay and PWM fan.
Author
There was a problem hiding this comment.
Alright, I think I got the big offenders.
Member
|
Thank you. Approving of the extra usermod hook :) |
added 6 commits
October 10, 2021 16:26
Contributor
|
@AK5nowman, due to recent commits, is it ready for merge? |
Author
|
@blazoncek yes, should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds overlay support to usermodsv2. It does not remove legacy overlay support from the main code base. Need to refactor the remaining overlay before that can be done.