ABL milliamps no longer hardcoded to 850 at runtime#2581
Merged
Aircoookie merged 1 commit intowled:masterfrom Mar 15, 2022
Merged
ABL milliamps no longer hardcoded to 850 at runtime#2581Aircoookie merged 1 commit intowled:masterfrom
Aircoookie merged 1 commit intowled:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a previous pull request I added "-D ABL_MILLIAMPS_DEFAULT", but it turns out that it didn't actually work because that variable wasn't applied everywhere it should have and was getting hard coded to 850. I also added a little math to make sure that if you use this -D override then it will always be at least 250 (I'm not exactly sure where 250 comes from, but if you try to set it to less than 250 in the GUI it gives a warning and won't let you save).