Fix cross-origin error in File Mode#2585
Merged
Aircoookie merged 3 commits intowled:masterfrom Mar 24, 2022
w00000dy:master
Merged
Fix cross-origin error in File Mode#2585Aircoookie merged 3 commits intowled:masterfrom w00000dy:master
Aircoookie merged 3 commits intowled:masterfrom
w00000dy:master
Conversation
Member
|
Hey! |
Contributor
Author
|
Hi! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,

when you use the UI in File Mode the Peek-Button does not work because of this error:
To fix this, I simply changed line 48 in
liveviewws.htmfromto
.
I'm a bit confused why you did implement it like this. As far as I know,
top.window.wsis the same asws. Or am I wrong here?Anyway, I tested File Mode and now I don't get this error anymore and the Peek-Button now works again:

Also in Online Mode Peek still works.