platformio sample cleanup#5190
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughRemoves multiple predefined PlatformIO build environment blocks from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I've left Athom for now as I know these are in common use and I don't know the current state of play with regards to their firmware |
| # ------------------------------------------------------------------------------ | ||
| # EleksTube-IPS | ||
| # ------------------------------------------------------------------------------ | ||
| [env:elekstube_ips] | ||
| extends = esp32 ;; use default esp32 platform | ||
| board = esp32dev | ||
| upload_speed = 921600 | ||
| custom_usermods = ${env:esp32dev.custom_usermods} RTC EleksTube_IPS | ||
| build_flags = ${common.build_flags} ${esp32.build_flags} -D WLED_DISABLE_BROWNOUT_DET -D WLED_DISABLE_INFRARED | ||
| -D DATA_PINS=12 | ||
| -D RLYPIN=27 | ||
| -D BTNPIN=34 | ||
| -D PIXEL_COUNTS=6 | ||
| # Display config | ||
| -D ST7789_DRIVER | ||
| -D TFT_WIDTH=135 | ||
| -D TFT_HEIGHT=240 | ||
| -D CGRAM_OFFSET | ||
| -D TFT_SDA_READ | ||
| -D TFT_MOSI=23 | ||
| -D TFT_SCLK=18 | ||
| -D TFT_DC=25 | ||
| -D TFT_RST=26 | ||
| -D SPI_FREQUENCY=40000000 | ||
| -D USER_SETUP_LOADED | ||
| monitor_filters = esp32_exception_decoder |
There was a problem hiding this comment.
This is a usermod example that's in the wrong place - probably a bad merge moved the header comment. I think it should get moved to the EleksTube_IPS usermod readme (and we should do the same with the RF433 example too)
|
Hey! This pull request has been open for quite some time without any new comments now. It will be closed automatically in a week if no further activity occurs. |
| ;; Warning: this build environment is not stable!! | ||
| ;; ESP32 env using ESP-IDF V4.4.x | ||
| ;; please erase your device before installing. | ||
| extends = esp32_idf_V4 # based on newer "esp-idf V4" platform environment |
There was a problem hiding this comment.
all buildenvs are "V4" now
-> replace with extends = esp32dev
--> remove everything else in this buildenv, only keep board_build.f_flash = 80000000L and board_build.flash_mode = dio
|
i.e. remove all |
Remove bespoke boards from platformio-override.sample.ini as these are not maintained
Summary by CodeRabbit