Skip to content

platformio sample cleanup#5190

Open
netmindz wants to merge 2 commits into
wled:mainfrom
netmindz:platformio_override-cleanup
Open

platformio sample cleanup#5190
netmindz wants to merge 2 commits into
wled:mainfrom
netmindz:platformio_override-cleanup

Conversation

@netmindz
Copy link
Copy Markdown
Member

@netmindz netmindz commented Dec 14, 2025

Remove bespoke boards from platformio-override.sample.ini as these are not maintained

Summary by CodeRabbit

  • Chores
    • Removed configuration entries for several legacy and specialized microcontroller boards from the sample build configuration, streamlining available setup options.
  • Documentation
    • Updated wording in a sample environment header to improve clarity and tone without changing its configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 14, 2025

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 36799955-dc32-4c9e-bc61-8da50723c4b3

📥 Commits

Reviewing files that changed from the base of the PR and between 4724dbc and 640a178.

📒 Files selected for processing (1)
  • platformio_override.sample.ini
🚧 Files skipped from review as they are similar to previous changes (1)
  • platformio_override.sample.ini

Walkthrough

Removes multiple predefined PlatformIO build environment blocks from platformio_override.sample.ini (legacy and specialized boards) and updates a descriptive header comment for the esp32dev_V4_dio80 environment; no new environments added and remaining env logic unchanged.

Changes

Cohort / File(s) Summary
Configuration cleanup
platformio_override.sample.ini
Deleted multiple [env:...] sections for legacy/specialized boards (heltec_wifi_kit_8, h803wf, esp8285_4CH_MagicHome, esp8285_H801, d1_mini_5CH_Shojo_PCB, anavi_miracle_controller, MY9291, codm-controller-0_6*, elekstube_ips, etc.). Removed associated board/platform/ldscript/build flags, lib_deps, upload/custom_usermods, and monitor_filters. Also updated the header comment for esp32dev_V4_dio80 without changing its configuration logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'platformio sample cleanup' is concise but vague. It describes a general maintenance action without specifying which boards or configurations are being removed, making it less clear than it could be for someone scanning the git history. Consider a more specific title like 'Remove unmaintained bespoke boards from platformio sample config' to better convey the main change.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@netmindz
Copy link
Copy Markdown
Member Author

I've left Athom for now as I know these are in common use and I don't know the current state of play with regards to their firmware

Comment on lines -506 to -531
# ------------------------------------------------------------------------------
# EleksTube-IPS
# ------------------------------------------------------------------------------
[env:elekstube_ips]
extends = esp32 ;; use default esp32 platform
board = esp32dev
upload_speed = 921600
custom_usermods = ${env:esp32dev.custom_usermods} RTC EleksTube_IPS
build_flags = ${common.build_flags} ${esp32.build_flags} -D WLED_DISABLE_BROWNOUT_DET -D WLED_DISABLE_INFRARED
-D DATA_PINS=12
-D RLYPIN=27
-D BTNPIN=34
-D PIXEL_COUNTS=6
# Display config
-D ST7789_DRIVER
-D TFT_WIDTH=135
-D TFT_HEIGHT=240
-D CGRAM_OFFSET
-D TFT_SDA_READ
-D TFT_MOSI=23
-D TFT_SCLK=18
-D TFT_DC=25
-D TFT_RST=26
-D SPI_FREQUENCY=40000000
-D USER_SETUP_LOADED
monitor_filters = esp32_exception_decoder
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a usermod example that's in the wrong place - probably a bad merge moved the header comment. I think it should get moved to the EleksTube_IPS usermod readme (and we should do the same with the RF433 example too)

@github-actions
Copy link
Copy Markdown

Hey! This pull request has been open for quite some time without any new comments now. It will be closed automatically in a week if no further activity occurs.
Thank you for contributing to WLED! ❤️

@github-actions github-actions Bot added the stale This issue will be closed soon because of prolonged inactivity label Apr 14, 2026
@netmindz netmindz added keep This issue will never become stale/closed automatically and removed stale This issue will be closed soon because of prolonged inactivity labels Apr 14, 2026
;; Warning: this build environment is not stable!!
;; ESP32 env using ESP-IDF V4.4.x
;; please erase your device before installing.
extends = esp32_idf_V4 # based on newer "esp-idf V4" platform environment
Copy link
Copy Markdown
Member

@softhack007 softhack007 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all buildenvs are "V4" now
-> replace with extends = esp32dev
--> remove everything else in this buildenv, only keep board_build.f_flash = 80000000L and board_build.flash_mode = dio

@DedeHai
Copy link
Copy Markdown
Collaborator

DedeHai commented May 23, 2026

#5643

i.e. remove all -D USERMOD_x and replace with correct syntax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

keep This issue will never become stale/closed automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants