docs: add canonical feature-flag list to copilot-instructions to catch misspellings#5487
Merged
softhack007 merged 4 commits intomainfrom Apr 8, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/wled/WLED/sessions/9679ab9c-e696-4b45-a4f7-273717ef15c6 Co-authored-by: softhack007 <91616163+softhack007@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
softhack007
April 8, 2026 20:33
View session
Member
|
@coderabbitai review. additionally, please check if the wording can be more concise without becoming less efficient. |
This comment was marked as outdated.
This comment was marked as outdated.
softhack007
reviewed
Apr 8, 2026
Updated feature-flag names and their descriptions for correctness.
Updated the list of WLED_DISABLE_* flags to include 'FILESYSTEM'.
pcmihnea
pushed a commit
to pcmihnea/WLED
that referenced
this pull request
Apr 13, 2026
…h misspellings (wled#5487) Misspelled WLED_ENABLE_* / WLED_DISABLE_* flags are silently ignored by the preprocessor, causing features to be incorrectly included or excluded with no compiler warning (e.g. WLED_IR_DISABLE instead of WLED_DISABLE_INFRARED). This PR adds an AI rule that enforces checking of feature flags against a curated list. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: softhack007 <91616163+softhack007@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misspelled
WLED_ENABLE_*/WLED_DISABLE_*flags are silently ignored by the preprocessor, causing features to be incorrectly included or excluded with no compiler warning (e.g.WLED_IR_DISABLEinstead ofWLED_DISABLE_INFRARED).Change
.github/copilot-instructions.md.WLED_DISABLE_*andWLED_ENABLE_*, derived directly from the codebase, so the agent can immediately identify any unrecognised flag as a likely typo and suggest the correct spelling.