Skip to content

0.16 - Backport dynarray fixes from V5 WIP#5497

Merged
willmmiles merged 5 commits intowled:16_xfrom
willmmiles:16_x-dynarray-fixes
Apr 12, 2026
Merged

0.16 - Backport dynarray fixes from V5 WIP#5497
willmmiles merged 5 commits intowled:16_xfrom
willmmiles:16_x-dynarray-fixes

Conversation

@willmmiles
Copy link
Copy Markdown
Member

@willmmiles willmmiles commented Apr 12, 2026 •
edited by coderabbitai bot
Loading

Bring in the dynarray/usermod improvements from the V5 work in progress. This improves the system to support LTO and framework = arduino, esp-idf, as well as fixes some issues with dynarray linkage on RISCV platforms.

fadc75d in particular should fix #5495

Summary by CodeRabbit

  • Refactor
    • Improved linker script injection mechanism for dynamic arrays to use inlined fragments instead of platform-specific files.
    • Enhanced module validation to use compilation-unit analysis for more reliable module confirmation across platforms.
    • Unified dynamic array section naming across all targets for consistency.

willmmiles and others added 5 commits April 12, 2026 10:02
@willmmiles @claude
dynarray: Directly apply linker fix
fadc75d 
Rather than append a linker file, we edit the upstream supplied ones to
add our section to the binaries.  Works better on all platforms.

Co-Authored-By: Claude <noreply@anthropic.com>
@willmmiles
Fix usermod count for LTO
c789e3d
@willmmiles
validate_modules: Improve performance
f994c5e 
Use readelf instead of nm for great speed.
@willmmiles
dynarray: Support ESP-IDF
fd890b3
@willmmiles @claude
Fix up usermod validation again
48ab88e 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 12, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 471e95d7-d3a2-43e6-991d-2526d3304b01

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

DedeHai
DedeHai approved these changes Apr 12, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@DedeHai DedeHai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can confirm it fixes the bootloop on C3

@willmmiles willmmiles merged commit 4cdc23a into wled:16_x Apr 12, 2026
24 checks passed
@netmindz netmindz added this to the 16.0.0 beta milestone Apr 12, 2026
@DedeHai
Copy link
Copy Markdown
Collaborator

DedeHai commented Apr 12, 2026

@willmmiles this also needs to go upstream

@willmmiles willmmiles mentioned this pull request Apr 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DedeHai DedeHai DedeHai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

16.0.0 beta

Development

Successfully merging this pull request may close these issues.

3 participants

@willmmiles @DedeHai @netmindz