Skip to content

Add identifier string for DMX realtime mode#5516

Merged
softhack007 merged 1 commit intowled:mainfrom
kilrah:fix_dmx_ident
Apr 19, 2026
Merged

Add identifier string for DMX realtime mode#5516
softhack007 merged 1 commit intowled:mainfrom
kilrah:fix_dmx_ident

Conversation

@kilrah
Copy link
Copy Markdown
Contributor

@kilrah kilrah commented Apr 18, 2026

Fix #5509

Rebased on main, replaces #5511

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 18, 2026

Walkthrough

Added a missing switch case in serializeInfo() to map REALTIME_MODE_DMX to the string representation "DMX" in the serialized JSON output, addressing the display of undefined mode for DMX input.

Changes

Cohort / File(s) Summary
DMX Mode Serialization
wled00/json.cpp
Added switch case mapping REALTIME_MODE_DMX to root["lm"] = "DMX" in serializeInfo() function to properly serialize DMX input mode.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding an identifier string for DMX realtime mode in the code.
Linked Issues check ✅ Passed The PR directly addresses issue #5509 by adding the missing DMX identifier string mapping, which resolves the 'undefined' display issue on the live data overlay.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to adding a single case statement for DMX mode mapping in serializeInfo, directly addressing the linked issue with no extraneous modifications.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@softhack007 softhack007 merged commit 3af2ae5 into wled:main Apr 19, 2026
25 checks passed
softhack007 added a commit that referenced this pull request Apr 19, 2026
Add identifier string for DMX realtime mode
softhack007 added a commit that referenced this pull request Apr 19, 2026
Add identifier string for DMX realtime mode
@kilrah kilrah deleted the fix_dmx_ident branch April 20, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[0.16 beta] DMX input is shown as "undefined" on the live data overlay

2 participants