GoL missing return.

[Brandon502]

Return likely was deleted when FRAMETIME was removed. This fixes speed slider and games restarting correctly.

Summary by CodeRabbit

• Bug Fixes
  • Fixed Game of Life effect to properly handle paused states and redraw cycles, preventing unnecessary processing that could impact performance during paused animations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 957920e9-12bb-46d5-b71b-70e6fc3332a2

📥 Commits

Reviewing files that changed from the base of the PR and between 01328a6 and 94c14a8.

📒 Files selected for processing (1)

• wled00/FX.cpp

---

Walkthrough

The mode_2Dgameoflife() function in FX.cpp now terminates early with a return statement when paused or in the redraw-only path, preventing subsequent "Repeat detection" and simulation update steps from executing during these conditions.

Changes

Cohort / File(s)	Summary
Game of Life Control Flow wled00/FX.cpp	Added early return statement in mode_2Dgameoflife() to exit after redraw logic when effect is paused or in between-update redraw path, preventing unintended continuation into repeat detection and simulation update operations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'GoL missing return.' directly and specifically identifies the main change—restoring a missing return statement in the Game of Life effect. It clearly summarizes the primary fix in the changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[DedeHai]

good call, I accidentally removed that return.