Skip to content

cleanup of PR #5503: remove unnecessary changes#5536

Merged
DedeHai merged 1 commit intowled:mainfrom
DedeHai:cleanup_PR_5503
Apr 25, 2026
Merged

cleanup of PR #5503: remove unnecessary changes#5536
DedeHai merged 1 commit intowled:mainfrom
DedeHai:cleanup_PR_5503

Conversation

@DedeHai
Copy link
Copy Markdown
Collaborator

@DedeHai DedeHai commented Apr 25, 2026

see comment in #5503

Summary by CodeRabbit

  • Refactor
    • Reordered initialization sequence during startup.
    • Removed unnecessary dependency declaration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4aa3bda1-759f-4dd0-813d-20985db5451c

📥 Commits

Reviewing files that changed from the base of the PR and between 1bc71f2 and b433603.

📒 Files selected for processing (1)
  • wled00/wled.cpp

Walkthrough

The PR relocates ESP32 RX noise-suppression initialization logic—specifically the GPIO pulldown enable and delay sequence—to an earlier point within WLED::setup(). The driver/gpio.h include is removed.

Changes

Cohort / File(s) Summary
ESP32 RX Noise-Suppression Timing
wled00/wled.cpp
Moves GPIO pulldown initialization (gpio_pulldown_en) earlier in setup sequence and removes associated driver/gpio.h include.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

bug

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references PR #5503 and indicates cleanup/removal of changes, which aligns with the code moving ESP32 RX noise-suppression logic and removing the driver/gpio.h include.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the bug label Apr 25, 2026
@DedeHai DedeHai added connectivity Issue regarding protocols, WiFi connection or availability of interfaces and removed bug labels Apr 25, 2026
@DedeHai DedeHai merged commit 49a63fc into wled:main Apr 25, 2026
25 checks passed
@DedeHai DedeHai deleted the cleanup_PR_5503 branch April 25, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

connectivity Issue regarding protocols, WiFi connection or availability of interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant