Skip to content

ci: opt into Node.js 24 for GitHub Actions runners#5546

Merged
netmindz merged 1 commit intowled:mainfrom
netmindz:node24
May 2, 2026
Merged

ci: opt into Node.js 24 for GitHub Actions runners#5546
netmindz merged 1 commit intowled:mainfrom
netmindz:node24

Conversation

@netmindz
Copy link
Copy Markdown
Member

@netmindz netmindz commented Apr 26, 2026

Set FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true across all affected workflows to avoid deprecation warnings ahead of the June 2026 forced migration.

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflows across build, nightly, release, and user modifications pipelines to use Node.js 24 for JavaScript-based actions.

Set FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true across all affected workflows
to avoid deprecation warnings ahead of the June 2026 forced migration.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7e2bdc90-532b-4dd1-ad53-cced70fb5a72

📥 Commits

Reviewing files that changed from the base of the PR and between a535c56 and 5f219e6.

📒 Files selected for processing (4)
  • .github/workflows/build.yml
  • .github/workflows/nightly.yml
  • .github/workflows/release.yml
  • .github/workflows/usermods.yml

Walkthrough

Adds the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable to four GitHub Actions workflow files, configuring JavaScript-based actions to execute under Node.js 24 across build, nightly, release, and usermods workflows.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/build.yml, .github/workflows/nightly.yml, .github/workflows/release.yml, .github/workflows/usermods.yml
Added workflow-level environment variable FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true to force JavaScript-based GitHub Actions to run under Node.js 24.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci: opt into Node.js 24 for GitHub Actions runners' clearly and accurately summarizes the main change: adding Node.js 24 opt-in configuration across CI workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@softhack007 softhack007 linked an issue Apr 30, 2026 that may be closed by this pull request
@softhack007
Copy link
Copy Markdown
Member

softhack007 commented Apr 30, 2026

@netmindz should we also update .nvmrc ("20.18") or is this file just for "npm" when called from platformio buildenvs?

@netmindz netmindz merged commit dd397fe into wled:main May 2, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub actions warning about deprecated Node.js 20 actions

2 participants