Fixed top-LED update logic in grav* audioreactive effects#5602
Conversation
Fix topLED fallrate not responding to "Rate of fall" parameter.
WalkthroughThis PR adjusts the threshold comparison in the ChangesGravity Center Top LED Offset Alignment
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DedeHai
left a comment
There was a problem hiding this comment.
thanks, since you tested the AI's suggestion, I am good with the change.
Added spaces
softhack007
left a comment
There was a problem hiding this comment.
looks good to me, thanks 👍
Fix topLED fallrate not responding to "Rate of fall" slider.
This patch should fix issue #5600
Summary by CodeRabbit