feat: Add Domraem Ethernet board support#5610
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis PR adds support for the Domraem_ETHV1 Ethernet board type by defining the type constant, updating the type count, configuring its GPIO pins and PHY, and exposing it in the settings UI dropdown. ChangesDomraem_ETHV1 Ethernet Board Type Support
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
does this supersed #5607? it conflicts. |
|
|
then please close the other one. |
|
|
can you explain the change from previous PR? Did you change hardware or was the old one untested? |
The only difference between the old PR #5607 and current PR #5610 is the eth_address value. |
Add support for Domraem ESP32 Ethernet hardware.
PHY addr: 0, Power: GPIO5, MDC: GPIO23, MDIO: GPIO33.
This is a generic board configuration for ESP32 + LAN8720 Ethernet.
Summary by CodeRabbit