Skip to content

feat: Add Domraem Ethernet board support#5610

Open
jacker-25 wants to merge 1 commit into
wled:mainfrom
jacker-25:domraem-eth-final
Open

feat: Add Domraem Ethernet board support#5610
jacker-25 wants to merge 1 commit into
wled:mainfrom
jacker-25:domraem-eth-final

Conversation

@jacker-25
Copy link
Copy Markdown

@jacker-25 jacker-25 commented May 13, 2026

Add support for Domraem ESP32 Ethernet hardware.
PHY addr: 0, Power: GPIO5, MDC: GPIO23, MDIO: GPIO33.
This is a generic board configuration for ESP32 + LAN8720 Ethernet.

Summary by CodeRabbit

  • New Features
    • Added support for a new Ethernet board type (Domraem_ETHV1), which is now available as an option in the Ethernet configuration settings.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e9db67b7-93ab-4d56-91d2-26939835e52b

📥 Commits

Reviewing files that changed from the base of the PR and between 8e94cf5 and 6b16515.

📒 Files selected for processing (3)
  • wled00/const.h
  • wled00/data/settings_wifi.htm
  • wled00/network.cpp

Walkthrough

This PR adds support for the Domraem_ETHV1 Ethernet board type by defining the type constant, updating the type count, configuring its GPIO pins and PHY, and exposing it in the settings UI dropdown.

Changes

Domraem_ETHV1 Ethernet Board Type Support

Layer / File(s) Summary
Board type ID definition
wled00/const.h
Define new board type constant WLED_ETH_DOMRAEM_ETHV1 with value 16 and increment WLED_NUM_ETH_TYPES from 16 to 17 to accommodate the new type.
Board configuration and UI integration
wled00/network.cpp, wled00/data/settings_wifi.htm
Add ethernetBoards[] entry for the new board type with GPIO pin configuration, LAN8720 PHY, and GPIO0 input clock; expose the new type as Domraem_ETHV1 option in the Ethernet Type dropdown.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • wled/WLED#5553: Extends the Ethernet board type registry with similar pattern of updating WLED_NUM_ETH_TYPES, adding UI option, and inserting ethernetBoards[] entry.
  • wled/WLED#5156: Adds a different LAN8720-based Ethernet board type using the same pattern of constant definition, UI option, and board configuration.
  • wled/WLED#5608: Implements compile-time validation of the ethernetBoards[] table length against WLED_NUM_ETH_TYPES, which validates this PR's table extension.

Suggested labels

enhancement

Suggested reviewers

  • softhack007
  • DedeHai
  • netmindz
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title directly and accurately describes the main change: adding support for a new Domraem Ethernet board type.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DedeHai
Copy link
Copy Markdown
Collaborator

DedeHai commented May 13, 2026

does this supersed #5607? it conflicts.

@jacker-25
Copy link
Copy Markdown
Author

这会取代#5607吗?这很矛盾。
Hello, this can replace #5607.

@DedeHai
Copy link
Copy Markdown
Collaborator

DedeHai commented May 13, 2026

then please close the other one.

@jacker-25
Copy link
Copy Markdown
Author

then please close the other one.
It has been closed now. Thank you.

@DedeHai
Copy link
Copy Markdown
Collaborator

DedeHai commented May 13, 2026

can you explain the change from previous PR? Did you change hardware or was the old one untested?

@jacker-25
Copy link
Copy Markdown
Author

jacker-25 commented May 13, 2026

can you explain the change from previous PR? Did you change hardware or was the old one untested?

The only difference between the old PR #5607 and current PR #5610 is the eth_address value.
The actual Domraem hardware uses eth_address=0, while the previous PR incorrectly set it to 1.
Gledopto configuration uses eth_address=1, so Domraem (eth_address=0) is a different hardware design and cannot reuse the existing Gledopto entry.
This new PR #5610 matches the real hardware schematic and has been verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants