Skip to content

fix button label regression#5636

Open
benjamw wants to merge 2 commits into
wled:mainfrom
benjamw:button_fix
Open

fix button label regression#5636
benjamw wants to merge 2 commits into
wled:mainfrom
benjamw:button_fix

Conversation

@benjamw
Copy link
Copy Markdown
Contributor

@benjamw benjamw commented May 21, 2026

This is a fix for Issue #5613

Summary by CodeRabbit

  • UI Updates
    • Updated the "Button Action Presets" section heading to clarify it's for switches.
    • Renamed per-row headers to indicate switch-specific buttons.
    • Refined preset macro labels to clearer action descriptions (e.g., Short, Long, Double press) for improved configuration clarity.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8aab2682-f107-490e-8b59-f7540b54b436

📥 Commits

Reviewing files that changed from the base of the PR and between af6df43 and a50d5e4.

📒 Files selected for processing (1)
  • wled00/data/settings_time.htm
✅ Files skipped from review due to trivial changes (1)
  • wled00/data/settings_time.htm

Walkthrough

Update button preset UI text in the time settings: per-row header changes to "Button (switch) ${i}", section heading to "Button (switch) Action Presets", and the MP/ML/MD preset select labels are reassigned as documented.

Changes

Button Action Preset UI Labels

Layer / File(s) Summary
Button row header and preset labels
wled00/data/settings_time.htm
Per-row header text in addRow() changed to "Button (switch) ${i)". Section heading changed to "Button (switch) Action Presets". The preset select labels were reassigned: MP = "Short (on → off)", ML = "Long (off → on)", MD = "Double press (n/a)".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix button label regression' directly addresses the main change—correcting button labels in the UI that had regressed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

also add switch notation
Copy link
Copy Markdown
Member

@softhack007 softhack007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@softhack007 softhack007 linked an issue May 22, 2026 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WLED - buttons label incorrect

2 participants