Make comment private when changing status from moderation or cancelled#487
Merged
Conversation
Finishes https://phabricator.wikimedia.org/T137328 Please verify the logic is correct. What I did is check if the status is either moderation or cancelled, as opposed to checking if the status is not external incomplete as described in the ticket. I suspect these are equivalent, though am not sure as the later is not very explicit.
| private function makeCommentPrivate() { | ||
| $this->comment = new DonationComment( | ||
| $this->comment->getCommentText(), | ||
| false, |
Contributor
There was a problem hiding this comment.
Should we use constants here?
Contributor
Author
There was a problem hiding this comment.
Maybe. The context here is very small and specific though. Anyway, feel free to make PR.
Another possibility for this code is to move it into a createPrivateCopy method in DonationComment.
Contributor
There was a problem hiding this comment.
Right, actually the method name says it all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes https://phabricator.wikimedia.org/T137328
Please verify the logic is correct. What I did is check if the status is either
moderation or cancelled, as opposed to checking if the status is not external
incomplete as described in the ticket. I suspect these are equivalent, though
am not sure as the later is not very explicit.