Conversation
Use Toolforge kubernetes infrastructure for the test system Bug: T263539
jakobw
left a comment
jakobw
left a comment
There was a problem hiding this comment.
Thanks for writing this up! Looks good to me! I mostly nitpicked around in the text and added one question as to why we're limited in our choice of docker images on Toollforge which I think would be nice to have covered.
|
|
||
| We also need a publicly accessible test setup to have its features tested by UX and PM once they land on the main branch. We also need a development environment, need a CI environment and so on. Each environment has its own unique requirements, for production we are not sure we would use pipeline as a node app or it will be part of the standard WDQS GUI assets. | ||
|
|
||
| Toolforge seems like a good setup for small projects due to its baked-in support of serving static assets using lighttpd or serving node10 apps. It has been changing and growing more mature. One of its most recent features is support for dockerized webservices and cronjobs using kubernetes. You can read more about it in [here](https://wikitech.wikimedia.org/wiki/Help:Toolforge/Kubernetes). We can't use our built Dockerfile in Toolforge and if we want to go in that direction, we would have to have a dedicated VM just for this service in CloudVPS instead and make it automatically updated using puppet or ansible which would be too much work for too little gain. |
There was a problem hiding this comment.
We can't use our built Dockerfile in Toolforge
I also had this in the back of my mind but reading this I was immediately wondering "why?!" because we are using a docker image from the WMF registry even for our development setup. Do you know if there's a piece of documentation that we can link to which explains this? If the reason is that only a fixed list of images is allowed there, then it may be as simple as linking to that list.
There was a problem hiding this comment.
I can ask around (and I couldn't find such documentation) but I assume it's because any arbitrary Dockerfile gives a big degree of freedom which could become problematic (noisy neighbour effect).
There was a problem hiding this comment.
The answer I got in IRC:
Amir1: you would then need to upload the resulting docker img to our toolforge registry, right? We don't support bring-your-own-container yet, even if it is based on the WMF docker registry
Co-authored-by: Jakob Warkotsch <jakob.warkotsch@wikimedia.de>
Co-authored-by: Jakob Warkotsch <jakob.warkotsch@wikimedia.de>
Co-authored-by: Jakob Warkotsch <jakob.warkotsch@wikimedia.de>
Co-authored-by: Jakob Warkotsch <jakob.warkotsch@wikimedia.de>
Co-authored-by: Jakob Warkotsch <jakob.warkotsch@wikimedia.de>
jakobw
left a comment
jakobw
left a comment
There was a problem hiding this comment.
LGTM ✨
I'd still be curious to hear from @bereket-WMDE whether this ADR answers all of his questions.
yes it does. I've some discussions about this with @Ladsgroup and adam about toolforge and its benefits. I was under the impression that toolforge is some VM and that was while i asked about the pipelines |
3 participants
Use Toolforge kubernetes infrastructure for the test system
Bug: T263539