This repository was archived by the owner on Mar 25, 2021. It is now read-only.
added methods searchEntities and searchItemValues#103
Merged
Conversation
this method is called by public searchProperties and searchItems methods: adjust the repository to also allow querying for items Add an action to use the repository to query for items Updated searchEntityRepo interfase Updated tests that use createActions Added tests specific to the method searchItemValues
guergana
commented
Dec 16, 2020
micgro42
suggested changes
Dec 17, 2020
Collaborator
micgro42
left a comment
micgro42
left a comment
There was a problem hiding this comment.
Nice! There are just some minor things to adjust
| expect( repo.searchItemValues( 'John Smith' ) ).rejects.toThrow( expectedError ); | ||
| } ); | ||
|
|
||
| it( 'throws an error if there is a server side problem fetching a property', () => { |
Collaborator
There was a problem hiding this comment.
No, this test should be about network errors, not server errors
Contributor
Author
There was a problem hiding this comment.
I deleted that one by accident it seems. Also duplicated one. It's a copy and paste mistake. Will fix.
Co-authored-by: Michael Große <michael.grosse@wikimedia.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this method is called by public searchProperties and searchItems methods:
adjust the repository to also allow querying for items
Add an action to use the repository to query for items
Updated searchEntityRepo interfase
Updated tests that use createActions
Added tests specific to the method searchItemValues