Limit component#119
Conversation
guergana
force-pushed
the
LimitComponent
branch
2 times, most recently
from
b67b932 to
82749a7
Compare
guergana
force-pushed
the
LimitComponent
branch
from
1a3f43e to
190e838
Compare
guergana
force-pushed
the
LimitComponent
branch
from
190e838 to
7b2d4b5
Compare
micgro42
left a comment
micgro42
left a comment
There was a problem hiding this comment.
It is a bit strange to add the action and mutation in the same PR as the component, but then not use it there. But since that is done in the following PR, it is not worth splitting this PR up
| name="limit" | ||
| v-model="checked" | ||
| /> | ||
| <label for="limit"> |
There was a problem hiding this comment.
the for attribute refers to an id, not a name, see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label#attr-for
There was a problem hiding this comment.
This will be merged in the other PR eventually. This is a mistake yes..
There was a problem hiding this comment.
This will be replaced, as the label, and even the component are going to be replaced. Will update it but I dont think it's worth spending much time on this part, tomorrow it will be probably decided how to handle this.
There was a problem hiding this comment.
If the idea is to merge #120 into this PR first, then I'm ok with it :)
There was a problem hiding this comment.
Oh, no. 😅 The idea was to merge this one into PR 118. I've updated this PR
guergana
force-pushed
the
LimitComponent
branch
from
7b2d4b5 to
4bd7b31
Compare
guergana
force-pushed
the
LimitComponent
branch
from
4bd7b31 to
33f295b
Compare
Let's ask the designers and then take a decision :) |
* added a Limit Component that allows to change limit * added useLimit action, getter and mutation to decide if limit number should be included in query * modified query representation to add limit only if useLimit is true
* added a Limit Component that allows to change limit * added useLimit action, getter and mutation to decide if limit number should be included in query * modified query representation to add limit only if useLimit is true
* added a Limit Component that allows to change limit * added useLimit action, getter and mutation to decide if limit number should be included in query * modified query representation to add limit only if useLimit is true
* added a Limit Component that allows to change limit * added useLimit action, getter and mutation to decide if limit number should be included in query * modified query representation to add limit only if useLimit is true
* added a Limit Component that allows to change limit * added useLimit action, getter and mutation to decide if limit number should be included in query * modified query representation to add limit only if useLimit is true
* added a Limit Component that allows to change limit * added useLimit action, getter and mutation to decide if limit number should be included in query * modified query representation to add limit only if useLimit is true
* added a Limit Component that allows to change limit * added useLimit action, getter and mutation to decide if limit number should be included in query * modified query representation to add limit only if useLimit is true
* added a Limit Component that allows to change limit * added useLimit action, getter and mutation to decide if limit number should be included in query * modified query representation to add limit only if useLimit is true
2 participants
added limit component.
Still missing some tests.
The validation of the number in the field needs to be discussed as well, also if
limit?is required or not and if it can be required conditionally whenuseLimit == true